馃悰 Better error message for File not found on fetch #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Improves the error message when a user tries to fetch a template when the file is not located
probably should look into what occurs when the file is found but is not a .zip or a template.pros, but I don't understand conductor well enough to fix that quickly
Motivation:
Current error messages don't indicate what is going on to the user.
Example:
ERROR - __main__:main - 'NoneType' object has no attribute 'split' - pros-cli version:3.5.0 File "pros/conductor/conductor.py", line 188, in resolve_template File "pros/conductor/conductor.py", line 174, in resolve_templates AttributeError: 'NoneType' object has no attribute 'split'Test Plan: