Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃Ч Remove PROS 4 Prompts #346

Merged
merged 1 commit into from
May 7, 2024
Merged

馃Ч Remove PROS 4 Prompts #346

merged 1 commit into from
May 7, 2024

Conversation

ayushuk
Copy link
Member

@ayushuk ayushuk commented May 7, 2024

Summary:

Remove PROS 4 prompts when enabling early access.

Motivation:

Support the PROS 4 GA as it is no longer early access.

Test Plan:

Generally, just make sure we didn't break existing functionality. Expecting normal functionality with the PROS 4 prompt removed.

  • Create normal PROS project (expected: normal project is created on latest mainline version)
  • Create early access PROS project (expected: early access project is created with latest early access version)

noam987
noam987 approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@noam987 noam987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the tests passed, LGTM

@ayushuk ayushuk merged commit 3335d17 into develop May 7, 2024
10 checks passed
@ayushuk ayushuk deleted the remove-pros4-prompts branch May 7, 2024 22:05
@ayushuk ayushuk mentioned this pull request May 7, 2024
Merged
This was referenced May 17, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noam987 noam987 noam987 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ayushuk @noam987