🧹Remove Okapilib as a default template for PROS 4 #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When creating a PROS 4 project, do not apply PROS 4 as a default template. Okapilib will behave as a normal template for PROS 4 and newer.
Motivation:
This change was requested for the release of PROS 4.
Test Plan:
Note on CLI release that PROS 4 will be the latest kernel version on mainline so we check if a project with the latest kernel version is used.
Create a PROS 3 project (okapi should be applied as a default template, old behavior)
Create a PROS 4 project (okapi should not be applied as a default template)
Create a PROS project with the latest version (okapi should not be applied, this is guaranteed to be a PROS 4 project or newer when the new CLI version releases)
