Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃毟 Apply liblvgl as a default template for PROS 4 #356

Merged
merged 1 commit into from
May 18, 2024

Conversation

ayushuk
Copy link
Member

@ayushuk ayushuk commented May 18, 2024

Summary:

Add liblvgl as a default template for only PROS 4 or newer projects.

Motivation:

As PROS 4 moves into mainline, liblvgl should become a default template as it was in the early access depot.

Test Plan:

It is not currently possible to test if liblvgl is applied when PROS 4 is in mainline but as proven from creating PROS 4 in early access, the template will be applied when creating a PROS 4 project regardless of depot. The test also proves liblvgl will not be applied when attempting to create a PROS 3 project.

  • Create a PROS 3 project (liblvgl should not be applied)
    Screenshot 2024-05-18 at 2 07 06鈥疨M

  • Create a PROS 4 project (liblvgl should be applied)
    Screenshot 2024-05-18 at 2 07 19鈥疨M

@ayushuk ayushuk changed the title apply liblvgl as a default template for pros 4 馃毟 Apply liblvgl as a default template for PROS 4 May 18, 2024
Copy link
Contributor

@mayankpatibandla mayankpatibandla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ayushuk ayushuk merged commit 025a945 into master May 18, 2024
8 checks passed
@ayushuk ayushuk deleted the hotfix/apply-lvgl-default branch May 18, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants