馃悰 Fix removing default template #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayankpatibandla
force-pushed
the
hotfix/remove-default-templates
branch
from
95a6d39
to
07385bb
Compare
12944qwerty
approved these changes
May 21, 2024
This was referenced May 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Instead of removing the template from the list, it will instead skip over it when applying the templates.
Motivation:
There is a bug introduced in 3.5.2 where okapilib is removed from the default templates list when creating a new project which causes issues when creating multiple projects.
Test Plan:
On
master:On
hotfix/remove-default-templates: