Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Applies liblvgl without expiremental features #360

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

noam987
Copy link
Contributor

@noam987 noam987 commented Jun 4, 2024

Summary:

Adjusts the default templates such that they are based on kernel version, not if you are in experimental / early access mode.
Has v5 be the default project in the project class. it is already set as the default in new conductor files.

Motivation:

Fixes the issue of liblvgl not being applied when you have never turned on early access.

Test Plan:

  • Creating a pros 4 project after reseting conductor applies only liblvgl
    image

  • Creating a pros 3 project applies only okapilib
    image

Copy link
Contributor

@mayankpatibandla mayankpatibandla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unable to reproduce the bug, but LGTM

@mayankpatibandla mayankpatibandla merged commit 6621736 into develop Jun 6, 2024
10 checks passed
@mayankpatibandla mayankpatibandla deleted the bugfix/lvgl-not-applied branch June 6, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants