Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 fix upload --name flag #361

Merged
merged 2 commits into from
Jun 6, 2024
Merged

馃悰 fix upload --name flag #361

merged 2 commits into from
Jun 6, 2024

Conversation

Rocky14683
Copy link
Member

@Rocky14683 Rocky14683 commented Jun 4, 2024 •
edited
Loading

Summary:

#308

  • Upload with --name
  • Upload without --name

noam987
noam987 approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@noam987 noam987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me if this works on hardware

@Rocky14683
Copy link
Member Author

I have a brain to test. It works fine

@mayankpatibandla mayankpatibandla merged commit a075f94 into develop Jun 6, 2024
10 checks passed
@mayankpatibandla mayankpatibandla deleted the fix-issue308 branch June 6, 2024 04:58
@mayankpatibandla mayankpatibandla mentioned this pull request Jun 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noam987 noam987 noam987 approved these changes

@mayankpatibandla mayankpatibandla Awaiting requested review from mayankpatibandla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rocky14683 @noam987 @mayankpatibandla