Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃挌 Add autocomplete scripts to PyInstaller #363

Merged
merged 1 commit into from
Jun 6, 2024
Merged

馃挌 Add autocomplete scripts to PyInstaller #363

merged 1 commit into from
Jun 6, 2024

Conversation

mayankpatibandla
Copy link
Contributor

@mayankpatibandla mayankpatibandla commented Jun 6, 2024 •
edited
Loading

Summary:

  • Includes that autocomplete shell scripts as data files for PyInstaller.
  • Removed . prefix from bash and zsh scripts because PyInstaller ignores them

Motivation:

After #341 the completion scripts are needed in order for the cli to function

Test Plan:

  • Ensure PyInstaller builds
  • Check if pros setup-autocomplete works

@mayankpatibandla mayankpatibandla self-assigned this Jun 6, 2024
@mayankpatibandla mayankpatibandla merged commit c321f20 into develop Jun 6, 2024
10 checks passed
@mayankpatibandla mayankpatibandla deleted the pyinstaller-bundle-autocomplete branch June 6, 2024 05:56
This was referenced Jun 6, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@12944qwerty 12944qwerty 12944qwerty approved these changes

Assignees

@mayankpatibandla mayankpatibandla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mayankpatibandla @12944qwerty