-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Upgrade LVGL to 5.3 #144
Conversation
- still need to test for some regressions - still need to test some 5.3 features
everything compiles right now, but important things (namely LLEMU) appear to be broken. |
attached is a kernel template built on commit bd6bb46 for anyone who's interested in helping debug (e.g. @Jerrylum) |
This comment has been minimized.
This comment has been minimized.
Ah, yes. One of the things we get in this upgrade is support for monospaced fonts, which I believe I set as the default. You should be able to switch back to the old (not monospaced) font with a call to |
the symbol should be |
per @edjubuh:
That's a good point. What I'll probably end up doing is just keeping the default font the same as it is, and changing LLEMU styles to explicitly use the monospaced version |
You can solve the problem by adding a delay at the first line of initialize function. I think we should be initializing LVGL before the system daemon, and the problem should be resolved. |
Thanks for the investigation, I'll give it a try at some point in the next few days or so. You're right that we should probably be initializing LVGL before running the competition tasks... I'm not entirely sure why it was working before but it seems to have been a fluke. |
@Jerrylum thanks again for the help, changing the order of initialization does seem to have fixed it |
I'm attaching a copy of the kernel from this PR (as of 890739f) so people can play around with it and tell me what's broken |
well this is... uh... progress? lv_obj_t* canvas;
static void* canvas_buf;
void initialize() {
canvas = lv_canvas_create(lv_scr_act(), NULL);
canvas_buf = malloc((lv_img_color_format_get_px_size(LV_IMG_CF_TRUE_COLOR) * 480 * 240)/ 8);
lv_canvas_set_buffer(canvas, canvas_buf, 480, 240, LV_IMG_CF_TRUE_COLOR);
lv_canvas_draw_circle(canvas, 240, 120, 60, lv_color_t{{0xFF,0xFF,0x00}}); // yellow
} |
I tested my screenlib on this, pretty much everything was the same. The text is printing a single 5x7 character on a 10x10 obj. If I remove everything except for aligning the label to the center of the cube, I get this branch printing 4 pixels right of the existing kernel. |
What font were you using? |
This one here |
Hm ok yeah. I'm pretty sure there were some changes made to the way that fonts are rendered (judging by the addition of support for monospace fonts). I wonder what would happen if you explicitly configured that font as such? See
|
First thing I noticed when I upgraded - my splashscreen image broke. Probably because the image was generated using the old convertor. Not much changed, it looks good. The only difference I noticed was under the angler page, in the button matrix on the left, the bottom button was expanded to fill the container. Most likely a bug fix. I will get the image working, but apart from that the upgrade looks successful. |
Hmmm... The image thing alone might warrant bumping to 3.2.0 |
I managed to get the image to work. However, it seems only |
Working splashscreen with transparency. I don't think I have anything else to test, aside from upgrading the image format, everything else worked properly. @HotelCalifornia do you want me to try to use the canvas? |
I was also getting the "no data" thing when setting raw color format on a canvas. I think I saw something about needing a custom decoder for that. That said, I had some ok results when using the indexed 8-bit format-- did you try that? Also I think @Jerrylum had some success with writing a bmp decoder that used 32-bit RGBA (which may actually be the same thing now I think about it) |
I did not try any indexed formats, but does it provide the transparency I need? My image is white, and the container background is orange, which is why the transparency is needed. When I have time I will test the reading from SD card. Last time I tried I couldn't get it to work (it just gave I know you have thought about it already, but I really think it is a good idea to provide LVGL as a template, which people can build on their own, and people can uninstall it and opt to install another template which contains the vexos screen wrappers. |
Ah, ok. Assuming that the 8-bit indexed format is actually RGBA, then yes, the "A" refers to an alpha (read: transparency) channel.
Yeah I have thought about it. There are a couple problems:
I suppose I could build a copy of the kernel with LVGL debugging turned on, if you think that would help |
I tested the LVGL Canvas feature and made a BMP image display function. This is the code: The result: The image I used in the code:
Size: 280px X 280px Download: Tools to made image: Pixelformer |
257296d
to
42c44df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor polishing changes that I'd like to see, otherwise it seems ready to get merged.
* Better errno for registry validation failure, update vision sensor errnos Summary: - Changed port number validation to return ENXIO when outside the domain of port numbers - Changed port validation to return ENODEV when the requested device doesn't match the actual device - Vision Sensor read/get functions consistently use EAGAIN when the libv5rts tells us it couldn't get data - Remove docstrings for EACCES since it is practically impossible to get that errno (we wait for mutex indefinitely) Test Plan: TBD * ✨ Add Makefile-variable for excluding libraries from cold image (#121) #### Summary: Someone want to enable 🔥/❄ function but he doesn't want to include all libraries in the cold image. So he adds this feature here. you can edit `EXCLUDE_COLD_LIBRARIES` to exclude the library. The library will be compiled every time you use `make` command. (🔥🔥🔥) #### Motivation: Add it. ##### References (optional): lazy to make an issue. 404 not found. #### Test Plan: - [x] Make a library for testing - [x] Make a new project and apply the testing library - [x] Compile with 🔥/❄ function (use `make all`) - [x] Upload and test if the library is running? - [x] Exclude the library - [x] Compile with 🔥/❄ function (use `make all`) - [x] Upload and test if the library is running? - [x] Change something in the project - [x] Compile with 🔥/❄ function (use `make`) - [x] Upload and test if the library is running? - [x] delete variable `EXCLUDE_COLD_LIBRARIES` - [x] Compile with 🔥/❄ function (use `make all`) - [x] Upload and test if the library is running? * Update vdml_vision.c * Update vdml_vision.c * Update vdml_vision.c * Update Copyright info to current year * 🐛 Fix cold libraries variable assignment (#129) * Apply suggestions from code review Co-Authored-By: edjubuh <edjubuh@elliotjb.com> * Fix whitespace * Fix up errno when mismatch/not connected * Fix up errno when mismatch/not connected for ADI * Fix up errno when mismatched/not connected for ADI round 2 * Fix up errno when mismatched/not connected for ADI round 3 * ✨ Improve Makefile compile speed (#123) #### Summary: Someone doesn't want to waste his time. So he adds this code to make compile-job faster. The compiler now doesn't need to remove and create `temp.log` every time it compiles a file. #### Motivation: Add it. ##### References (optional): close #103 #### Test Plan: - [x] Call `make all` - [x] Call `make` - [x] Try to compile with no error - [x] Try to compile with warning - [x] Try to compile with error #### Commits: * ✨ Improve Makefile compile speed * Use only variables; use printf * Keep changes from #119 * Do not treat strings as escaped * Migate kernel makefile to test_output_2 (#130) #### Summary: Migrate kernel makefile to `test_output_2` and make make make again. #### Motivation: It's broken because `@cd` isn't a command. `@` was supposed to suppress echoing the whole command, but `test_output` has changed. ##### References (optional): #123 #### Test Plan: - [X] It build * Fix incorrect port type (#139) #### Summary: Fix incorrect port type in some motor functions #### Motivation: They were different from everywhere else with seemingly no reason. #### Test Plan: - [x] Still compiles * Add alternate generic serial API and fix generic serial filesystem driver (#141) * Add alternate serial API * Fix generic serial files * Add serial tests * Fix dev_read_r and dev_write_r starving tasks * Revert DEVCTL_SET_BAUDRATE to maintain compatibility * Update generic serial test * Modify blocking serial sleep time * Move serial include * Change serial telemetry function names * 🐛 Update vision_read_by_sig to be less funky (#124) * Update vision_read_by_sig to properly transform all coordinates and respect array boundaries Summary: - We weren't properly respecting array boundaries on read_by_sig, now we are Test Plan: - [x] @kdcrafter tested in T659 and throughout Worlds * Update vdml_vision.c * 🚨 Make things work with GCC 8.3 (#155) * add __sync_synchronize stub * catch exception by reference to suppress new warning * move mlock functions to their own file to fix newlib * 🔧 Enable hot/cold by default (#154) * 🏗 Combine template source files (#152) * Rename main.c to startup.c * Combine initialize, autonomous, and opcontrol into main * Patch Makefile * Patch template-Makefile * Don't change USE_PACKAGE in this PR * 🐛 Fix multiple ADI bugs and inconsistencies (#151) * Fix IntelliSense error * Note possible hack with registry pad * Note possible issue with claim_port * Cleanup ADI C API * Remove config clear from ADI destructor * Move ADI config to initilizer list * Fix double normalization of ultrasonic port * Partially Revert "Remove config clear from ADI destructor" This partially reverts commit 6a562ef. * Declare ADIPort destructor as default * Revert "Note possible hack with registry pad" This reverts commit 866067b. * Change claim_port note * ⬆️ Upgrade LVGL to 5.3 (#144) * [wip] rollback point * finish upgrade\? doubt it * update lv_conf * make everything compile - still need to test for some regressions - still need to test some 5.3 features * initialize LVGL before system daemon * make non-monospaced font the default again * limit LLEMU screen to 33 monospace chars * clean versions * add comment about system_daemon_initialize * 🤫 Suppress ignored qualifiers when including lvgl (#147) * 🔧 Add default `.gitignore` to template (#156) * 🚸 Add alternate constructor for pros::Task (#158) * Alternate Task contructor: ommission of prio and stack_depth while still allowing access to name * Delegation of truncated constructor to the normal constructor * 💚 Update toolchain installation for azure (#163) * update toolchain installation for azure the PPA was hanging, and it installs an old version anyway * Update azure-pipelines.yml Co-Authored-By: Elliot Berman <berman5@purdue.edu> * 🚨🔊 Add a better Data Abort Handler (#112) * Add WIP of a better DataAbortHandler * More WIP * Cleanup * refactor some things * Refactor, clean up, and documentation * More comments * Update unwind.c * Tweak printfs * Add custom build of newlib * Include libc/libm in template * Exclude libc/libm from being included in cold image * check whether pc is in the hot zone * test unwind with hot/cold linking * Add support for unwinding through hot code * Clean up for PR * Undo USE_PACKAGE:=1 * remove leftover include * move __env_lock/__env_unlock to src/system/envlock.c missed this in #155, but these two functions are moved to their own file for the same reason as __malloc_lock/__malloc_unlock were-- to follow the override scheme that newlib expects. found the right filename from here: https://newlib.sourceware.narkive.com/aXWplROp/queries-concerning-rtos-protection-in-newllib * lint files * Update .arclint whitespace * 🐛 Add default LLEMU init code back to main.cpp (#165) * 🐛 adddefault LLEMU init code back to main.cpp * add documentation comment for callback function * Bump to 3.2.0 * 🔧 Recompile on header change (#167) * implemented header dependency tracking * Added dependency folder to the makefile * fix bug in making c folders * Renamed POSTCOMPILE * Undo unwanted changes * Modify template gitignore * Ignore clean errors * 🐛 Return proper error code for VDML functions that return floating point numbers (#160) * 🐛 Fix problem of return PROS_ERR_F error code * 🐛 Improve condition statement and comment VDML function 🤫 forgot to change * 🐛 Undo claim_port_try code to avoid warning 🐛 Undo claim_port_try code to avoid warning * 🐛 Fix motor PID functions bug (#162)
Summary:
Upgrades LVGL to 5.3 release
Motivation:
everyone reeeealllly wants this
References (optional):
Should unblock #110 and by extension purduesigbots/liblvgl#13
Closes #92
Test Plan: