fixed recent file list not being saved on macOS, dont save loglevel a…

…s array; removed extra call to write_recentfiles in menu clear

tcl/pd_guiprefs.tcl

@@ -19,6 +19,7 @@ set ::recentfiles_key ""
 set ::loglevel_key "loglevel"
 set ::pd_guiprefs::domain ""
 set ::pd_guiprefs::configdir ""
+set ::recentfiles_is_array false
 
 #################################################################
 # perferences storage locations
@@ -55,15 +56,13 @@ set ::pd_guiprefs::configdir ""
 #
 #################################################################
 
-
 #################################################################
 # global procedures
 #################################################################
 # ------------------------------------------------------------------------------
 # init preferences
 #
 proc ::pd_guiprefs::init {} {
-    set arr 0
     set ::pd_guiprefs::domain org.puredata.pd.pd-gui
 
     switch -- $::platform {
@@ -88,7 +87,7 @@ proc ::pd_guiprefs::init {} {
             set ::recentfiles_key "NSRecentDocuments"
             set ::total_recentfiles 10
             # osx special case for arrays
-            set arr 1
+            set ::recentfiles_is_array true
 
             # ------------------------------------------------------------------------------
             # osx: read a plist file
@@ -99,9 +98,16 @@ proc ::pd_guiprefs::init {} {
                         set conf [plist_array_to_tcl_list $conf]
                     }
                 } else {
-                    # initialize NSRecentDocuments with an empty array
-                    exec defaults write $adomain $akey -array
-                    set conf {}
+                    # value not found, so set empty value
+                    if {$arr} {
+                        # initialize w/ empty array for NSRecentDocuments, etc
+                        exec defaults write $adomain $akey -array
+                        set conf {}
+                    } else {
+                        # not an array
+                        exec defaults write $adomain $akey ""
+                        set ""
+                    }
                 }
                 return $conf
             }
@@ -120,21 +126,21 @@ proc ::pd_guiprefs::init {} {
                 if {$arr} {
                     foreach filepath $data {
                         set escaped [escape_for_plist $filepath]
-                        exec /bin/sh -c "defaults write $adomain $akey $escaped"
+                        exec /bin/sh -c "defaults write $adomain $akey -array-add $escaped"
                     }
                 } else {
                     set escaped [escape_for_plist $data]
                     exec /bin/sh -c "defaults write $adomain $akey $escaped"
                 }
-
-                # Disable window state saving by default for 10.7+ as there is a chance
-                # pd will hang on start due to conflicting patch resources until the state
-                # is purged. State saving will still work, it just has to be explicitly
-                # asked for by holding the Option/Alt button when quitting via the File
-                # menu or with the Cmd+Q key binding.
-                exec defaults write $adomain NSQuitAlwaysKeepsWindows -bool false
                 return
             }
+
+            # Disable window state saving by default for 10.7+ as there is a chance
+            # pd will hang on start due to conflicting patch resources until the state
+            # is purged. State saving will still work, it just has to be explicitly
+            # asked for by holding the Option/Alt button when quitting via the File
+            # menu or with the Cmd+Q key binding.
+            exec defaults write $::pd_guiprefs::domain NSQuitAlwaysKeepsWindows -bool false
         }
         "registry" {
             # windows uses registry
@@ -196,11 +202,10 @@ proc ::pd_guiprefs::init {} {
 
     }
     # assign gui preferences
-    set ::recentfiles_list ""
+    set ::recentfiles_list {}
     catch {set ::recentfiles_list [get_config $::pd_guiprefs::domain \
-                                       $::recentfiles_key $arr]}
-    catch {set ::loglevel [get_config $::pd_guiprefs::domain \
-                                       $::loglevel_key $arr]}
+                                       $::recentfiles_key $::recentfiles_is_array]}
+    catch {set ::loglevel [get_config $::pd_guiprefs::domain $::loglevel_key]}
     # reset default if value was not found
     if {$::loglevel == ""} {set ::loglevel 2}
 }
@@ -344,17 +349,16 @@ proc ::pd_guiprefs::escape_for_plist {str} {
     return '[regsub -all -- {'} $str {\\'}]'
 }
 
-
 #################################################################
 # recent files
 #################################################################
 
-
 # ------------------------------------------------------------------------------
 # write recent files
 #
 proc ::pd_guiprefs::write_recentfiles {} {
-    write_config $::recentfiles_list $::pd_guiprefs::domain $::recentfiles_key true
+    write_config $::recentfiles_list $::pd_guiprefs::domain $::recentfiles_key \
+                 $::recentfiles_is_array
 }
 
 # ------------------------------------------------------------------------------
@@ -378,5 +382,5 @@ proc ::pd_guiprefs::update_recentfiles {afile} {
 # write log level
 #
 proc ::pd_guiprefs::write_loglevel {} {
-    write_config $::loglevel $::pd_guiprefs::domain $::loglevel_key true
+    write_config $::loglevel $::pd_guiprefs::domain $::loglevel_key
 }

tcl/pd_menus.tcl

@@ -370,10 +370,9 @@ proc ::pd_menus::update_recentfiles_menu {{write true}} {
 }
 
 proc ::pd_menus::clear_recentfiles_menu {} {
+    # empty recentfiles in preferences (write empty array)
     set ::recentfiles_list {}
     ::pd_menus::update_recentfiles_menu
-    # empty recentfiles in preferences (write empty array)
-    ::pd_guiprefs::write_recentfiles
 }
 
 proc ::pd_menus::update_openrecent_menu_aqua {mymenu {write}} {