-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gatom-nbx consistencies #1015
Closed
Closed
gatom-nbx consistencies #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit does not delete the inlet/outlet of gatom boxes when you insert a send/receive name. This make it consistent to the behavior of iemguis such as [nbx]. For this, I created a special atom_drawborder function that is called under gatom_vis and gatom_displace, this function calls a second glist_drawiofor_atoms function to draw the inlet/outlet.
[nbx] also allows this and it is pertinent/resonable for something like 1e+10. partially closes pure-data#851 see pure-data#851 (comment)
When you click on an atom box, there's no time limit for you to type a value, but [nbx] has a 3 sec limit. This removes the limit. This partially attends one of the issues discussed in pure-data#851 - more specifically in pure-data#851 (comment)
…er number along with the previous 2 commits, this fully closes pure-data#851 see pure-data#851 (comment)
This was referenced May 17, 2020
this indicates that an atom has been clicked and is ready to be typed in by thickening its width by a factor of 2. closes pure-data#1013
this is an improvement over the visual cue for gatom activity. Whem toggling in the number box, the object flashes only, like a message box - because when you do it, the object does not stay active so you can keep typing number values into it. this is yet another commit that now fully fullfills and closes pure-data#1013
this makes the size consistent between atom boxes with width = 0 to the soze of atom boxes with setted sizes. The discrepancy was very very minimal. In order to make it fit, the boxes with setted width need to to be 2 pixels wider and pixel higher - this height is also consistent to the height of objects and other elements. closes pure-data#1017
I should reboot this PR, some things like #1013 have already been implemented |
doing it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on commits that aim to improve the consistency regardng the behaviour of gatom boxes and nbx].
Commit 85f6d2b keeps i/olet functionality for gatom boxes when you have send/receive symbols and closes #1005
Commits d802831 / b1f48aa / 8aefaa4 Close #851
commit d2ce38e closes #1025
commits e40e64d & d6c5130 close #1013
But it also depends on commit 74878fa that closes #1032