Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set pd_this for readsf and writesf child threads #1227

Merged
merged 1 commit into from
Dec 15, 2020
Merged

set pd_this for readsf and writesf child threads #1227

merged 1 commit into from
Dec 15, 2020

Conversation

Ant1r
Copy link
Contributor

@Ant1r Ant1r commented Nov 21, 2020

When Pd (or libpd) is compiled with PDINSTANCE and PDTHREADS, the child threads of [readsf~] and [writesf~] need to have pd_this correctly initialized to the pd_instance that owns the object, else Pd crashes.

This closes #1225

@Ant1r Ant1r mentioned this pull request Nov 21, 2020
Closed
@NiallMoody NiallMoody mentioned this pull request Dec 9, 2020
Open
@danomatika danomatika mentioned this pull request Dec 10, 2020
Merged
12 tasks
@millerpuckette millerpuckette merged commit c864143 into pure-data:master Dec 15, 2020
@Ant1r Ant1r deleted the fix_readwritesf_instance branch October 22, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@millerpuckette millerpuckette

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[readsf~] segfaults in multithread+multiinstance context
2 participants
@Ant1r @millerpuckette