Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates from test3 feedback #123

Merged
merged 17 commits into from Jul 21, 2017
Merged

updates from test3 feedback #123

merged 17 commits into from Jul 21, 2017

Conversation

danomatika
Copy link
Contributor

@danomatika danomatika commented Jul 20, 2017

  • update to latest deken
  • fix missing Audio on/off translation strings
  • recent files menu not populating on macOS
  • deken search button width too small for translations
  • remove midiin & sysexin Windows warnings in x_midi.c (& update help file)?
  • add Windows autotools build info to INSTALL.txt (Dan is working on this now)

@porres
Copy link
Contributor

porres commented Jul 20, 2017

probably more related to deken, but nonetheless a translation issue:

"show all" gets cropped in other languages, such as in portuguese with "mostrar todos". Make it a little bigger?

Another remark is that there is a text saying "To get a list of all available externals, try an empty search" - but this seems obvious with the "show all" button, when the search field is empty.

@porres
Copy link
Contributor

porres commented Jul 20, 2017

Another thing I'm having an issue with translating is "Send a Pd message". I think this is wrong, and the original should be "Send Pd a message", cause that's what it does, right?

Another suggestion is to mark this in the File Menu as "Message to Pd..." instead of just "Message..." - this would make it much clearer

…s array; removed extra call to write_recentfiles in menu clear
@danomatika
Copy link
Contributor Author

The recent files not being saved issue should be fixed in the latest commit. This was a mac issue but would probably be good to test on other platforms to make sure.

@danomatika
Copy link
Contributor Author

danomatika commented Jul 20, 2017 via email

@danomatika
Copy link
Contributor Author

danomatika commented Jul 20, 2017 via email

@porres
Copy link
Contributor

porres commented Jul 20, 2017

sorry, I got the "message" thing really wrong

@porres
Copy link
Contributor

porres commented Jul 20, 2017

Open an issue on the pure-data/deken repo for this.

done: pure-data/deken#154

@millerpuckette millerpuckette merged commit d499641 into master Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants