Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[file] new verbs 'isabsolute', 'normalize', 'cwd', 'patchpath' #1590

Merged
merged 7 commits into from
Jun 6, 2023

Conversation

umlaeute
Copy link
Contributor

this adds 4 new subcommands to [file]:

the file-help.pd reference has also been updated accordingly, which will most likely lead to conflicts with #1517.
i have first synched the reference patch with #1517 (as of 675591a), so i guess the resolution would be to use the file-help.pd of this PR.

@umlaeute umlaeute added feature suggestion for an enhancement improvement improves an existing functionality without adding new features labels Mar 23, 2022
@umlaeute
Copy link
Contributor Author

out of mere habit this PR is based on develop...

@Spacechild1
Copy link
Contributor

out of mere habit this PR is based on develop...

why not rebase onto master? ;-)

src/x_file.c Outdated Show resolved Hide resolved
@umlaeute
Copy link
Contributor Author

umlaeute commented Dec 9, 2022

@millerpuckette what do you think about this? is this something that you do not want in principle? or that ought to be implemented differently? that needs more thinking?

has the ship sailed for new features in Pd-0.53?

note that this PR is actually driven by some requests by others (notably @Spacechild1; but also a few others chimed in)

@Spacechild1
Copy link
Contributor

@millerpuckette It would be really great if this could make it into Pd 0.54!

@millerpuckette millerpuckette merged commit cfd4623 into master Jun 6, 2023
@umlaeute umlaeute deleted the feature/file branch June 6, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature suggestion for an enhancement improvement improves an existing functionality without adding new features
Projects
None yet
3 participants