fix '-n' flag for [drawnumber]/[plot] #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should be '0' (pure black) not '1'
order was wrong. this is just misleading and throws people off. Nothing changes or gets fixed besides code clarity
umlaeute
added
the
bug/fix
|
I'm scared to try to do a merge-by-hand on this one right now. The color handling changed in another marge. I thonk the "-n" is a useful addition but I've been hearing that I shouldn't cherry-pick commits out of other peoples' PRs :) |
|
let me check this and try a new reboot |
@millerpuckette I did not rebooted it, I just fixed the conflicts. It now respects the color handling change from the previous merge, so it's all fine. Besides the '-n' flag, i only fixed the default argument and made minor change in the code order to follow the "RGB" order. Would you consider merging this now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1616
closes #1615
It also fixes minor issues in the later commits