fix [route] rejected output for bang input with float arguments #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently, nothing is output, this fixes it closes pure-data#1678
|
@umlaeute would you consider this as a fix for the development branch? |
Spacechild1
reviewed
May 30, 2022
|
From the PR description I don't really understand what problem it tries to solve. Can you share a minimal patch? (screenshot is ok) Unfortunately, the corresponding issue (#1678) isn't any clearer :-) |
|
sending a bang into [route] with float arguments should send a bang to the rightmost rejected outet, but nothing happens...
|
|
I see, thanks! From the description I thought you meant |
Oh, I see that now... well, seems like a simple bug fix, hopefully this is considered a no brainer and included in the development branch |
|
Also seems like a no-brainer to me, |
This comment was marked as resolved.
This comment was marked as resolved.
reducing number of redundant lines
Spacechild1
reviewed
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, nothing is output, this fixes it
closes #1678