Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fixes #1897

Merged
merged 23 commits into from
Jun 9, 2023
Merged

Documentation fixes #1897

merged 23 commits into from
Jun 9, 2023

Conversation

porres
Copy link
Contributor

@porres porres commented Feb 15, 2023

my usual documentation fixes, revisions and improvements.

So far we have:

porres referenced this pull request Apr 19, 2023
log~ and pow~ are bonops these got moved to d_aritmetic.c.  (The files
d_math.c and d_aritmetic.c should really be named "unop" and "binop".)

Also, makefile.gnu to accept pipewire jack-compatible API
removed a send object because of an unexisting send address and improved things a bit by using [list store] in the analysis subpatch
I am editing the new additions to conform with the current standard in the references part and I also added examples on how multichannels work in a subpatch.
@porres
Copy link
Contributor Author

porres commented Jun 4, 2023

Ok @millerpuckette thanks for merging this but I didn't get why it remained and persisted here.

I added a new commit for adding examples to [adc~] and [dac~] help files, so you may want to try and merge this again so it disappears from the PR list, and I'll be quiet with changes for a while, until test releases are up.

I'm afraid that some changes to the partialtracer example were not merged, so please try again

and thanks!

@porres
Copy link
Contributor Author

porres commented Jun 4, 2023

actually, now I see that what you have in master is my old adc~ and dac~ help file without the new info on adc~ multichannel support, so you really need to merge this to get the latest help file with this information and an example

@Lucarda Lucarda mentioned this pull request Jun 6, 2023
porres added 11 commits June 6, 2023 10:26
added block conflict information according to the discussion in pure-data#697 (comment)
I added "updated for 0.54" instead of 53 and made other minor cosmetic changes
…essages'

with the new functionality to [pdcontrol] I have added "see also" and related [pdcontrol] to [namecanvas] and 'pdmessages'.
I've split the 'math' help into trigonometric and unary functions, I also unified signal unaty operators into a single help file. This makes much more sense and I think things are much much more well organized this way.

Miller actually pointed this out and original discussion is in pure-data@bc7c20b#commitcomment-110029092

This closes pure-data/pddp#146
I wanted to point how you can also use [phasor~] and [cos~] to implement [osc~] but the only use case is to implement phase modulation so I went ahead and also created a simple phase modulation example
I'm now using the same 'unary'/'binary' description for math objects
@millerpuckette millerpuckette merged commit 3ae9fd1 into pure-data:master Jun 9, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve [delcare]'s help file reorganizing math help files.
3 participants