Add signal comparison/logical operators #2054
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spacechild1
added
feature
Spacechild1
force-pushed
the
sig_math_comp
branch
from
a0c99ad
to
0a9e5e0
Compare
|
If this is taken, I think it would make sense to have this objects call a new help file named binops-other-tilde-help.pd. For the record, I see most of the objects from binops-other-help.pd are here, all but [&], [|], [<<], [div] and [mod~] and yeah, I don't think they'd be worth including. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe the new multichannel feature is a good excuse to finally(!) add the missing signal comparison/logical operators:
[==~], [!=~],[>~],[<~],[>=~],[<=~],[&&~],[||~]IMO, it is a bit silly that we currently need externals (
zexy,cyclone) or[expr~]for these basic math operations, even more so as the former are (still) single channel.As a first step, I have added more convenience functions to
d_arithmetic.cwhich remove a lot of the code duplication. In total, this PR only adds 350 lines (700 added, 350 removed).Side note: it would be possible to further reduce the code size - drastically! - by implementing the perform routines as macros, taking the binary operator as an argument, but this might be a bit controversial, so I haven't done it.