allow to change the number of tables/channels in table DSP objects #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the "set" message can now resize the DSP array vector. However, it does not require a DSP graph update because we do not pass t_dsparray pointers directly to the perform routine; instead we pass the t_arrayvec member together with the channel index. tabwrite~ and tabsend~ just take the number of channels from their signal inlet, as they already did. tabplay~, tabread~, tabread4~ and tabreceive~ now have a "channels" method that allows to dynamically set the number of output channels - independently from the "set" method.
Spacechild1
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reboot of #2055. Thanks to @umlaeute for the crucial hint!
The "set" message may now resize the DSP array vector. However, it does not require a DSP graph update because we do not pass
t_dsparraypointers directly to the perform routine; instead we pass thet_arrayvecmember together with the channel index. The size of the vector is independent from the input/output channel count.tabwrite~andtabsend~continue to take the number of channels from their signal inlet. The only difference is that the number of tables is not fixed at creation time anymore.tabplay~,tabread~,tabread4~andtabreceive~now also have a "channels" method that allows to dynamically set the number of output channels (independently from the "set" method).Tested successfully with all objects.
Closed #2025