Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] bugfixes/improvements for pd~ #349

Closed
wants to merge 8 commits into from

Commits on Apr 7, 2018

  1. fix typo

    Christof Ressi committed Apr 7, 2018
    Copy the full SHA
    7d2540d View commit details
    Browse the repository at this point in the history
  2. quote paths in argument vector if they contain whitespace (and aren't…

    … quoted already)
    
    _spawnv validates the argument vector, treating whitespace within a cstring as a delimiter.
    this means that a path containing whitespace is passed as separate arguments to the subprocess, messing up the argument parsing.
    this is a problem on Windows because Pd is usually installed in "C:\Program Files (x86)"
    Christof Ressi committed Apr 7, 2018
    Copy the full SHA
    2c577d2 View commit details
    Browse the repository at this point in the history
  3. add cast to surpress warning for _spawnv

    Christof Ressi committed Apr 7, 2018
    Copy the full SHA
    1ea937d View commit details
    Browse the repository at this point in the history
  4. fix/improve pd_tilde_readmessages

    * return if no binary message could be read
    * add exit status
    Christof Ressi committed Apr 7, 2018
    Copy the full SHA
    89e2ba5 View commit details
    Browse the repository at this point in the history
  5. close files when pd_tilde_readmessages returns failure

    Christof Ressi committed Apr 7, 2018
    Copy the full SHA
    53f68ed View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    90b3ee5 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2018

  1. implement asynchronous reading from subprocess via a child thread and…

    … properly handle bad vector sizes
    Christof Ressi committed Apr 17, 2018
    Copy the full SHA
    57716f0 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2018

  1. fixed small memleak

    umlaeute committed May 8, 2018
    Copy the full SHA
    fb1f65a View commit details
    Browse the repository at this point in the history