[WIP] OS X retina support #6
Conversation
danomatika
changed the title
|
Updating to TCL/TK 8.5 also fixes the duplicate Preferences entry for the audio, midi, etc settings which are available in the Audio menu anyway.
However, now the Startup menu option is gone ... |
|
wow a blast from the past. This kind of stuff was fixed in pd-extended
5 years ago...
|
|
Yup. Trying to get some of it in vanilla in very small chunks. |
|
@eighthave Also, do you have any notes on TK 8.5? I'm finding the menu accelerators and global bindings are causing events to happen twice now. That and the canvas loses focus after a menu event so an object created from the Put menu doesn't follow the mouse when you move back to the canvas. |
|
@eighthave Also+, the font is too thin on retina. Is there a way to reenable antialiasing on the canvas? I know ::tk::mac::antialiasing is on but that only seems to affect general Tk widgets. |
|
I remember addressing that stuff, but I don't remember the details. Try
Pd-extended, and if it works, then you know where to look for the code :)
|
|
@eighthave I've been working with the vanilla & extended tcl dirs side by side. Alot is the same thanks your work merging in the gui updates. I haven't looked into anything on the C side yet as I'm not sure how to compile Pd as port audio seems really outdated on the latest OSX. |
|
Figured out the thin font is due to the default being Monaco. It just renders really thin at that size, probably since it's a higher resolution font file that comes with OSX. Changing the font to Courier yields a Pd that looks more "normal". |
|
@eighthave So it seems like you fixed all of these by using a non-broken TK build. The build in TK 8.5 that comes with OS X is 8.5.9 which seems to have a number of problems (lots of noise in the python community due to problems with IDLE). Looking in to Pd-extended, you were bundling Tcl & TK as frameworks within the app bundle. I'm looking into doing that again, at least as an option. |
|
yes, including a recent Tcl/Tk bulid with the OSX Pd.app has been
working for 10+ years
|
|
Ok cool. I started by digging into vanilla first, so I'm basically reverse engineering what y'all did with extended. Building Tcl/TK is easy at least. Here's a screenshot of Pd running Tcl/Tk 8.5.19. It looks like the font rendering was improved for retina screens (looks great!):
|
|
...and all the double bindings & a few other problems are now fixed. Great. |
…dwindow menubar after its created; moved require apple events to init_for_platform so tk mac event handling is used when running pd from the commandline; added ShowHelp apple event
… wiht tcltk-wish & use included Wish.app by default
…er & focus relative to current window stack
…r/less bindings conflict with comma/period bindings in Tk Cocoa so only set them on Win/Linux; some whitespace formatting fixes
… automatically; added menu_objectlist proc to show help-intro.pd instead as List objects... menu entry was being disabled due missing return value in command
…vious scrollbar fix
…already does this, also add small sleep for Tk 8.4 to avoid pdsend socket error
…do not stay in window list, this matches behavior when windows are closed via pd core; disable highlight in aboutpd dialog
…in a 1x1 canvas window
Apply string substitution to version number then update CFBundleVersion with resulting value
Required for additional macOS application build scripts.
CFBundleVersion updating for macOS builds
…e-data into osx-bundle-version
|
accepted with extreme prejudice |
|
@danomatika given that this has been merged (despite the WIP), should/can we delete the |
This is a reference PR. Do not merge.
Some small additions to enable crisp rendering on high dpi displays in OSX. Basically use Tk 8.5 and a newer Wish Shell.app (included) and add a key to the Info.plist.
Some comparison screenshots.
Non retina:
Retina:
TODO