Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing [midiclkin] / updating the help files of [float], [value] and [send] #79

Closed
wants to merge 3 commits into from

Conversation

porres
Copy link
Contributor

@porres porres commented Jun 29, 2017

About the first commit: I simply removed all about 'midiclkin' from Pd, and I was able to compile it in MacOS Sierra...

I added missing information about the relationship between these objects
@porres
Copy link
Contributor Author

porres commented Jun 29, 2017

about the second commit: I updated the help files of [float], [value] and [send] to include "hidden" information about the relationship between these objects - that is how a [send] can talk to a [value], and then how [float] can also send a number to a [value] object

@porres porres changed the title removing [midiclkin] removing [midiclkin] / updating the help files of [float], [value] and [send] Jun 29, 2017
@porres
Copy link
Contributor Author

porres commented Jun 30, 2017

why is the "AppVeyor build" failing?

@umlaeute
Copy link
Contributor

i think you should start doing pull-requests that only deal with a specific issue: either fix [midiclkin] or update the help-patches.
it makes it much easier for the person who merges the PRs to pick only the features they want and not those they don't want to.

the AppVeyor build fails because it tries to build even though it appveyor is not configured for your branch (the build consequently shouldn't even be attempted. I'm going to file a support request with appveyor).
for now, this can safely be ignored.

@umlaeute
Copy link
Contributor

you might want to read the documentation.

basically each PR is attached to a single branch. whatever you push to this branch, will end up in the PR.
On this very page, github tells you this explicitely. If you look just below my post, you should see something like:

Add more commits by pushing to the master branch on porres/pure-data.

IIRC I already tried to explain this in detail a while ago...

@porres porres closed this Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants