Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pure assumes it will be installed in ~/.config/fish and errors when it's not #250

Closed
mattmc3 opened this issue Dec 20, 2020 · 1 comment
Closed
Labels
🐛 bug something that doesn't works as expected

Comments

@mattmc3
Copy link
Contributor

mattmc3 commented Dec 20, 2020

Env

Pure

3.3.0

Fish

fish, version 3.1.2

OS/distribution

macOS Big Sur 11.1

Error received when loading Pure without using Fisher/OMF/Fundle

source: Error encountered while sourcing file '/Users/mattmc3/.config/fish/functions/_pure_uninstall.fish':
source: No such file or directory

Reason for error:

I believe Pure is assuming that it will be installed in my ~/.config/fish directory, but I am instead sourcing it from an alternative location by adding its functions and completions to $fish_function_path and $fish_complete_path.

Proposed fix:

This line is the culprit:

# conf.d/_pure_init.fish
# bad assumption that $__fish_config_dir is where Pure will live
source $__fish_config_dir/functions/_pure_uninstall.fish

It could be changed to something like this:

source (realpath (status --current-filename)/../../functions/_pure_uninstall.fish)
@jorgebucaran
Copy link
Contributor

Yep, see also #245 (comment)

edouard-lopez pushed a commit that referenced this issue Dec 21, 2020
Source _pure_uninstall.fish using relative paths in the pure project rather than assuming pure is in $__fish_config_dir
@edouard-lopez edouard-lopez added the 🐛 bug something that doesn't works as expected label Dec 21, 2020
edouard-lopez pushed a commit that referenced this issue Aug 21, 2023
Source _pure_uninstall.fish using relative paths in the pure project rather than assuming pure is in $__fish_config_dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug something that doesn't works as expected
Projects
None yet
Development

No branches or pull requests

3 participants