Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise the vi mode indicator to ❮ for non-insert modes #140

Merged
merged 11 commits into from
Feb 19, 2019
Merged

Revise the vi mode indicator to ❮ for non-insert modes #140

merged 11 commits into from
Feb 19, 2019

Commits on Feb 19, 2019

  1. Revise the vi mode indicator to ❮ for non-insert 

    This commit changes the default behavior of the prompt in vi mode.

Previously, the prompt retained the fish shell's default mode indicator:
it would print `[I]`, `[N]`, or `[V]` to indicate whether the user was
in insert, normal, or visual mode.

After this commit, the prompt will flip to `❮` whenever the user is not
in insert mode.  This matches the behavior of the zsh version of Pure.

The user can restore the prior functionality by setting the
`pure_reverse_prompt_symbol_in_vimode` variable to `false` in their
conf.d/pure.fish file.
    @codesections @edouard-lopez
    codesections authored and edouard-lopez committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    ae149c8 View commit details
    Browse the repository at this point in the history

  2. Simplify code testing settings for vi_mode symbol

    @codesections @edouard-lopez
    codesections authored and edouard-lopez committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    58e63dc View commit details
    Browse the repository at this point in the history

  3. Add test for pure_reverse_prompt_symbol_in_vimode

    @codesections @edouard-lopez
    codesections authored and edouard-lopez committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    6b030a4 View commit details
    Browse the repository at this point in the history

  4. fix merge conflict

    @edouard-lopez
    edouard-lopez committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    484a74e View commit details
    Browse the repository at this point in the history

  5. correct import path (use $current_dirname)

    @edouard-lopez
    edouard-lopez committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    12edd51 View commit details
    Browse the repository at this point in the history

  6. extract _pure_get_prompt_symbol method

    @edouard-lopez
    edouard-lopez committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    c62d052 View commit details
    Browse the repository at this point in the history

  7. correct variable name

    @edouard-lopez
    edouard-lopez committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    c72242e View commit details
    Browse the repository at this point in the history

  8. import _pure_get_prompt_symbol.fish in tests

    @edouard-lopez
    edouard-lopez committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    ef543ef View commit details
    Browse the repository at this point in the history

  9. bump pure_version to 2.1.0 

    fixes pure-fish#139
    @edouard-lopez
    edouard-lopez committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    587cfa0 View commit details
    Browse the repository at this point in the history

  10. rename variable to pure_symbol_reverse_prompt

    @edouard-lopez
    edouard-lopez committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    8726bb9 View commit details
    Browse the repository at this point in the history

  11. quote variable when checking for emptyness

    @edouard-lopez
    edouard-lopez committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    b9714a2 View commit details
    Browse the repository at this point in the history