Fix command duration issues, also add show subsecond support #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novadev94
changed the title
novadev94
force-pushed
the
fix/command_duration_rounding
branch
from
c13e5c2
to
de39f76
Compare
edouard-lopez
added
🐛 bug
edouard-lopez
force-pushed
the
fix/command_duration_rounding
branch
from
de39f76
to
6bc7f07
Compare
- Fix command duration rounding: Duration wasn't shown when:
+ When threshold = 5 (5000ms)
+ When process finished in [5000, 6000) miliseconds
- Fix command duration threshold: Duration wasn't shown when:
+ When threshold = 5 (5000ms)
+ When process finished in 1m4s (64 seconds)
- Add support for showing subsecond in command duration
via `pure_show_subsecond_command_duration`
edouard-lopez
force-pushed
the
fix/command_duration_rounding
branch
from
6bc7f07
to
6086ac2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
via
pure_show_subsecond_command_duration