Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stash indicator #222

Closed
wants to merge 1 commit into from
Closed

feat: add stash indicator #222

wants to merge 1 commit into from

Conversation

Arelav
Copy link

@Arelav Arelav commented May 14, 2020

It's pretty far to be ready. And it's not so straight forward like was mentioned in the #218
This is my attempt to implement stash indicator.
If it helps I'll be happy to share my progress.
I have no experience in Fish scripting. I'm only a user.
So with many help it could be done however I need a review for this PR and direct instructions what I missed.

P.S. Please don't be surprised by many changes in README. Most of them is a result of the work of MD plugin I have installed.

@edouard-lopez
Copy link
Member

Fish has a bunch of functions and variables related to status I was unaware of (maybe they have been introduced in fish 3, didn't check). Nonetheless, maybe they can be of use to us to simplify our code:
https://fishshell.com/docs/current/cmds/fish_git_prompt.html?highlight=stash

@edouard-lopez edouard-lopez added the 🚀 enhancement performance, UX or maintainability label Dec 1, 2020
@edouard-lopez
Copy link
Member

Thanks for your work

I didn't had permission to push to your repo so I created #239 to be able to merge the feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 enhancement performance, UX or maintainability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants