feature single line prompt #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prevent error message: > test: Missing argument at index 2
edouard-lopez
force-pushed
the
feature-single-line-prompt
branch
from
68dcfa0
to
7bc2f20
Compare
edouard-lopez
force-pushed
the
feature-single-line-prompt
branch
from
7bc2f20
to
a5aa785
Compare
|
@jorgebucaran could you have a look at the tests, I can't figure out why they are failing? Behaviour is hectic, I try to purge variables before each test, but doesn't seem to work. I might be missing something, so another opinion will help ✌️ |
|
@edouard-lopez I'm currently rewriting Fishtape, so maybe after that! 👍 |
* _purge_configs * _disable_colors * _print_filename
…prevent race condition
Run before all test files
edouard-lopez
force-pushed
the
feature-single-line-prompt
branch
from
e10ab2d
to
4394121
Compare
edouard-lopez
force-pushed
the
feature-single-line-prompt
branch
from
4394121
to
307d2f1
Compare
|
I'm having pretty weird behaviour with It works locally, I'm wondering if colouring is a problem here as I call them like @mesg (_print_filename $current_filename)with _print_filename defined like: function _print_filename --argument-names filename
echo (set_color cyan)$filename(set_color normal)
end |
|
TAP is a text-only format, so you shouldn't use color. |
edouard-lopez
force-pushed
the
feature-single-line-prompt
branch
from
307d2f1
to
2c24946
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #65
pure_enable_single_line_promptfalsetrue: Compact prompt as a single linePreview