Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish_title: add setting to configure pwd dir length #307

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

ovv
Copy link
Contributor

@ovv ovv commented Oct 22, 2022

Add new pure_title_dir_length setting (default to 0) to configure the pwd dir length. 0 means complete directory name.

example with path '/foo/example/bar':

  • pure_title_dir_length=0 -> '/foo/example/bar'
  • pure_title_dir_length=1 -> '/f/e/bar'
  • pure_title_dir_length=2 -> '/fo/ex/bar'

@ovv ovv force-pushed the ovv/terminal-title-dir-length branch from fb3b035 to 51b568b Compare October 22, 2022 22:10
Copy link
Member

@edouard-lopez edouard-lopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal, I made some suggestions

conf.d/pure.fish Outdated Show resolved Hide resolved
tests/fish_title.test.fish Show resolved Hide resolved
functions/fish_title.fish Show resolved Hide resolved
tests/fish_title.test.fish Show resolved Hide resolved
@ovv ovv force-pushed the ovv/terminal-title-dir-length branch from 4dffa3b to adca61d Compare October 27, 2022 20:45
Copy link
Member

@edouard-lopez edouard-lopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could take the time to:

functions/fish_title.fish Show resolved Hide resolved
@ovv ovv force-pushed the ovv/terminal-title-dir-length branch from adca61d to 71eff34 Compare November 3, 2022 16:39
@ovv
Copy link
Contributor Author

ovv commented Nov 3, 2022

@edouard-lopez updated

@ovv ovv force-pushed the ovv/terminal-title-dir-length branch 2 times, most recently from 5837581 to e74f11f Compare November 3, 2022 16:47
@edouard-lopez
Copy link
Member

Hello @ovv,
Could you rebase your branch master and document your feature so we can merge it?

Add new pure_title_dir_length setting (default to 0) to configure the
pwd dir length. 0 means complete directory name.

example with path '/foo/example/bar':
* pure_title_dir_length=0 -> '/foo/example/bar'
* pure_title_dir_length=1 -> '/f/e/bar'
* pure_title_dir_length=2 -> '/fo/ex/bar'
@ovv ovv force-pushed the ovv/terminal-title-dir-length branch from e74f11f to 7ca8172 Compare July 27, 2023 20:12
@ovv
Copy link
Contributor Author

ovv commented Jul 27, 2023

SHould be good to go. Let me know if more documentation is needed

@edouard-lopez edouard-lopez merged commit 7879160 into pure-fish:master Aug 1, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants