Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate suggestions from #34 #63

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Incorporate suggestions from #34 #63

merged 1 commit into from
Jul 10, 2018

Conversation

mwilliammyers
Copy link
Contributor

Incorporate suggestions from #34

  • Simplify setting git_status
  • Simplify __parse_git_branch by using echo instead of string

Simplify __parse_git_branch by using `echo` instead of `string`
Copy link
Collaborator

@rafaelrinaldi rafaelrinaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@edouard-lopez edouard-lopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwilliammyers Thanks for the follow up!

Would you be interested to add some tests related to your PR?

For instance on __parse_git_branch, you can write 2 test:

  • works on default branch

    1. setup a git repo (before each test),
    2. check current branch is master
  • works after checkout

    1. setup a git repo (before each test),
    2. create a new branch whatever
    3. checktout to whatever
    4. check branch name is whatever

@rafaelrinaldi
Copy link
Collaborator

@edouard-lopez This looks good to me as is but I also like your suggestions. Let's tackle this in a separate PR so this doesn't get blocked, ok?

Thanks again @mwilliammyers for sending this PR. This is a great addition.

@rafaelrinaldi rafaelrinaldi merged commit b5b0d64 into pure-fish:master Jul 10, 2018
@rafaelrinaldi rafaelrinaldi mentioned this pull request Jul 10, 2018
6 tasks
@edouard-lopez edouard-lopez modified the milestone: v2.0.0 Jan 9, 2019
edouard-lopez pushed a commit that referenced this pull request Aug 21, 2023
Incorporate suggestions from #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants