Call prompt as a single function

[andreiborisov]

Reimplement workaround for truncated strings (#49) using single function as currently recommended in fish-shell/fish-shell#904 (comment) instead of event handler.

Update first line of the prompt when moving through directory history with "Alt + ←" and "Alt + →" (#66).

Also resolve #62 and #67.

[andreiborisov]

I'm using default fish prompt_pwd when first line is too long, but we can do this in more fancier ways similar to https://github.com/sindresorhus/pure and try to minimise current directory in several increasingly strict steps.

[andreiborisov]

Re-comitted to fix Travis tests as suggested by #70 (comment)

[boyeborg]

@schrodincat I think the reason why the travis build fails is due to the dist: xenial option within the travis configuration. See #71

[rafaelrinaldi]

@schrodincat Could you please update your local version of pure and confirm if the issue still persists?

cc @boyeborg

[edouard-lopez]

@schrodincat test are green, could you resolve the conflict so we can move forward with your PR?

If you can add tests it's even better! 🎉

[andreiborisov]

Will fix this tomorrow, sorry for the delay😔

[andreiborisov]

Manual install script was a little bit broken (#81), but after fixing it, I haven't noticed any problems whatsoever. It seems, merge conflict was due to some spaces or other nonsense.

I didn't add any tests yet, though.

[rafaelrinaldi]

I appreciate your efforts here @schrodincat.

[andreiborisov]

Seems fine even after recent changes. @rafaelrinaldi feel free to let me know, if something need to be changed.
I’m also interested in implementing Git async functionality.

_{Sent with GitHawk}

[edouard-lopez]

Thanks for the many PRs!

I added some feedback in order to improve our code 👍

[andreiborisov]

@edouard-lopez I’ll look into it and fix it at Tuesday. Thanks for the review🌚

_{Sent with GitHawk}

[andreiborisov]

I'm terribly sorry for such long delay. I've refactored my PR with feedback from @edouard-lopez in mind.
I've tried to be as generic as possible so code can be more easily maintained. Basically, I've divided pre prompt to elements each with three components: preferred delimiter before element, styling and text itself. This way we can easily count symbols so we won't exceed limit of columns in terminal. Also actual relative position of elements defined right before prompt printing, which will help if we'll want to incorporate more structure altering settings.

[andreiborisov]

This approach also fixes multiple spaces before git arrows

[edouard-lopez]

@schrodincat Thanks for the work ❤️

Would you bear with me to ask for a bit more work?

As the file starts to be pretty big, I provided some guidance to split the file in smaller functions/files that we can include using source.
This will help other contribute as files will be smaller thus less scary and allow us to tests each file/functions.

If my comment are not clear enough ping me, we can discuss together

[edouard-lopez]

@schrodincat could you allow changes on your PR so I can resolve conflict by rebasing it on master and help with the work?

[andreiborisov]

@schrodincat could you allow changes on your PR so I can resolve conflict by rebasing it on master and help with the work?

They're already allowed

[andreiborisov]

@edouard-lopez I'm working on the PR right now, please, wait, before making changes

[andreiborisov]

Phew, I hope, this time everything is dandy😅

[edouard-lopez]

Awesome work! ❤️

Now there is plenty of things we can tests and thanks to you it will be a lot easier to do so and prevent further bug 👏