Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note workaround in README for Oh My Fish users #89

Merged

Conversation

benedictleejh
Copy link
Contributor

Add a note in the README for Oh My Fish users that explains how to workaround Oh My Fish not supporting conf.d snippets currently

@edouard-lopez
Copy link
Member

Thanks @benedictleejh

@rafaelrinaldi I would prefer to keep the readme as simple as possible, could you enable the wiki for the project so we can put the detailed explanation there and only keep the command line?

I'm reducing the PR to the command to execute and a link to the wiki page

The wiki page could contains :

Oh-My-Fish not currently supporting conf.d snippets in plugins and themes

Due to Oh My Fish not currently supporting conf.d snippets in plugins and themes (oh-my-fish/oh-my-fish#646),
an additional step to add the snippets to fish's conf.d is needed to have the prompt work correctly.

omf install pure
ln -s $OMF_PATH/themes/pure/conf.d/pure.fish ~/.config/fish/conf.d/pure.fish

Note: Use $XDG_CONFIG_HOME/fish to find the path to your fish configuration directory if the XDG_CONFIG_HOME environment variable is set on your system.

wiki page need to be created see discussion in pure-fish#89
@derekstavis
Copy link

This should be now fixed by oh-my-fish/oh-my-fish#653. To test it, use the omf dev channel (see omf help on how to switch channels).

@edouard-lopez
Copy link
Member

Thanks @derekstavis for the update.

@benedictleejh would you mind testing the dev channel feature against your issue?

@benedictleejh
Copy link
Contributor Author

I've switched to the dev channel to test, but it doesn't solve the issue. My suspicion is that the new conf.d loading in Oh-My-Fish only works with plugins, and not themes, because themes are handled differently from packages. I haven't had the time to test against a plugin using conf.d yet.

@edouard-lopez
Copy link
Member

edouard-lopez commented Nov 20, 2018

@benedictleejh Thanks for the quick feedback 👍

I'm merging as the issue still stand with OMF dev channel.

@rafaelrinaldi could you open the wiki as described in my first comment?

@edouard-lopez edouard-lopez merged commit 4cbceeb into pure-fish:master Nov 20, 2018
edouard-lopez added a commit that referenced this pull request Aug 21, 2023
wiki page need to be created see discussion in #89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants