Add a Cron4s config writer #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruippeixotog
requested changes
Apr 12, 2019
| ConfigReader.fromString(str => | ||
| Cron.parse(str).fold( | ||
| err => Left(CannotConvert(str, "CronExpr", err.getMessage)), | ||
| cronExpr => Right(cronExpr))) | ||
|
|
||
| implicit val cronExprConfigWriter: ConfigWriter[CronExpr] = |
There was a problem hiding this comment.
Can you combine the reader and writer parts in a ConfigConvert? You should be able to do that easily with ConfigConvert.viaString (see pureconfig-joda for examples).
There was a problem hiding this comment.
@ruippeixotog thanks to the pointer to ConfigConvert, wasn't aware of its existance. Should be sorted now.
jcazevedo
approved these changes
Apr 13, 2019
ruippeixotog
approved these changes
Apr 13, 2019
|
@alonsodomin Thanks for your contribution. Please consider sending a PR to add yourself to the pureconfig contributors list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.