Make output visible for delve #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
This pull request introduces 1 alert when merging 77f21dd into 9e833b2 - view on LGTM.com new alerts:
|
puremourning
force-pushed
the
delve-output
branch
from
77f21dd
to
268ae97
Compare
The delve-dap debug adapter doesn't send its output to the correct channel via dap, rather prints to its own stdout. This behaviour is buggy, but it seems that it's the job of every DAP client to fix it rather than fixing it at source. My solutin is to allow adapter specs to say that they need to be run in a terminal rather than a background job. This would in theory allow for stdin to work too. An alternative, or perhaps complementary, solution would be to attach the stdin/out of the 'channel-based server job' to a buffer and inlcude that in the Output window.
puremourning
force-pushed
the
delve-output
branch
from
268ae97
to
7bb4754
Compare
|
This pull request introduces 1 alert when merging 9e70896 into 9e833b2 - view on LGTM.com new alerts:
|
For cpptools, just use x86 binraies, as that apparently works. For lua and c-sharp, skip.
puremourning
force-pushed
the
delve-output
branch
from
b317417
to
4fcd07d
Compare
puremourning
force-pushed
the
delve-output
branch
from
4fcd07d
to
b8504d8
Compare
|
I had to drop support for the output window because of some weird deadlock where the channel isn't closing properly on shutdown, although the job is stopped. I think the terminal version is better anyway. |
puremourning
commented
Dec 30, 2021
There was a problem hiding this comment.
Reviewed 4 of 6 files at r1, 15 of 17 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @puremourning)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #504
There are two mechanisms implemented here - using a terminal buffer and using the Output window.
I'm actually not sure which is better. For now tty is the default for delve. This can be decided by using the following:
Setting "tty" to
falsewill instead put the output in a new "Adapter" tab in the Output window.