-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pulp run
's loader stub file can interfere with module names, should be kept in a temp directory
#26
Comments
|
It's because main.js is picked up as the main module, but the default skeleton creates a |
`main.js` clashes with the skeleton's default `Main` module - Node will load `main.js`, rather than `Main/index.js` upon calling `require('Main')`. By renaming from `main.js` to something else, node will load the proper module. Fixes purescript-contrib#26
Proposed solution would be to not store the wrapper file inside the build directory at all, rather using the |
pulp run
's loader stub file can interfere with module names, should be kept in a temp directory
I appreciate it's not an all encompassing solution but that is besides the point of the pull request. The initial experience of starting with pulp is what mattered to me. If I change things, I can expect unforeseen things to happen. |
I appreciate that, I'd still like to get the correct solution in asap. And I'm working on it as we speak, give me a moment. :) |
That commit introduces a Type error in |
That's curious. What Node version are you on, just for reference? The docs have that parameter down as optional. |
The docs specify the parameter as optional only if the other optional parameter |
The code seems to willingly accept both, but I agree with your interpretation of the doc. JS is terrible. :( It did run correctly in its previous form on my v0.12.0 version of Node, though, which is why I'm puzzled. |
The README does not make specific mention of it but am I correct to assume that a
pulp init && pulp run
should work without errors?I am getting:
The text was updated successfully, but these errors were encountered: