Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How does --monochrome work? #367

Open
i-am-the-slime opened this issue Jan 21, 2019 · 4 comments
Open

How does --monochrome work? #367

i-am-the-slime opened this issue Jan 21, 2019 · 4 comments

Comments

@i-am-the-slime
Copy link

If I specify pulp --monochrome build my output is still coloured. Am I doing something wrong?
I'm on macOS with pulp version 12.3.1.

@hdgarrood
Copy link
Collaborator

It might be that pulp is invoking a subprocess but failing to pass on the message that it should not use coloured output. Can you share the command you used, and the output you got?

@i-am-the-slime
Copy link
Author

I use pulp --monochrome build. From within fish shell. I thought that might be related but I tried from bash and still got colours.

@hdgarrood
Copy link
Collaborator

Is the coloured output coming from the compiler itself? I think what might have happened here is that the --monochrome option in pulp was implemented before the compiler started using colour codes in its output, and that when the compiler did start using colour codes in its output, nobody noticed that this is violating people's expectations about what --monochrome will do.

@nwolverson
Copy link
Collaborator

Looks like --monochrome was piped to psa, but not purs (and certainly I recall psa as colourful) - so if you're using psa, that should be taken care of.

I saw when colour was added to the compiler there was a suggestion to support --monochrome there that doesn't seem to be realised:
purescript/purescript#2079 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants