Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check dependency status before invoking psc? #69

Closed
hdgarrood opened this issue Jul 29, 2015 · 6 comments
Closed

Check dependency status before invoking psc? #69

hdgarrood opened this issue Jul 29, 2015 · 6 comments

Comments

@hdgarrood
Copy link
Collaborator

I often forget to bower i before I pulp build. It might be nice if pulp checked that the dependencies listed in bower.json were coherent with what is installed in bower_components before it invoked any of the compiler programs (psc, psc-bundle, etc).

@bodil
Copy link
Collaborator

bodil commented Jul 29, 2015

I wouldn't want that to be a strict requirement, but if you're able to perform a test like that cheaply (ie. no noticeable slowdown) then I wouldn't be opposed to printing a warning message about it.

@garyb
Copy link
Member

garyb commented Jul 29, 2015

Yeah, I'm not sure there's a great way of doing this without writing your own check. Invoking bower to do anything is slow as it checks whether it needs updating periodically, and also checks versions with the registry too when doing bower list.

@hdgarrood
Copy link
Collaborator Author

Bower has the --offline flag to prevent it from doing that, psc-publish uses this.

@garyb
Copy link
Member

garyb commented Jul 29, 2015

Oh right, nice! I wish I'd known about that earlier.

@hdgarrood
Copy link
Collaborator Author

Note to self: bower list --offline --json seems to be what we want, but isn't amazingly fast. It takes 1.34s for me on pulp as of 10.0.0, which has quite a few purescript dependencies but not that many. The output includes a missing: true for packages that haven't been installed.

@hdgarrood
Copy link
Collaborator Author

I'm not going to get around to this any time soon and it doesn't look as if anyone else will, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants