-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning on build: No files found using pattern: src/**/*.js #84
Comments
Yep, it's a warning - when we first introduced the FFI that uses external files there were two separate arguments for supplying the locations of PureScript and JS files - we then added a warning for when a path is specified that matches no files (which is what you're seeing here) - but the most recent change was to make it so one path glob can be used to specify both JS and PS files. I've not opened a PR yet, as not everyone using Pulp will necessarily be on the latest compiler version, so I was intending on waiting until we cut a 0.8 release before doing so. |
I have no idea what the comments here mean in terms of this being resolved or not. What I would like to suggest is that sooner rather than later the confusing-alarming-apparently-noise-not-signal-at-least-to-newbies message
go away. $0.02 intending to help the entire PureScript experience be more streamlined so more people want to use it instead of getting quickly scared away. |
Yes, we understand this, and it's going to happen. Please don't rush us. |
(Is it anything I can do in a PR, or is there too much nuance for me to make any useful example commits? I mean I expect there's a way you want it done, and 99 million other ways not to do it.) |
This is the issue that holds it up a bit purescript/purescript#1937. @hdgarrood would a |
Yeah that seems like it should work. Directories won't have dots in their names in most cases, at least not if people are following the (almost universal) convention of file names relating to module names. I personally don't mind imposing that requirement for pulp too much. |
A workaround could be to just ignore directories in the compiler. |
I think that's the fix, not a workaround 😄... for "workaround" I was thinking of changes we could make in pulp alone. |
Ah, but the linked issue suggests recursively enumerating files inside directories. Edit: sorry, I misread it. Didn't realize it suggested either/both. |
And I didn't realise it suggested that 😄 |
I'm not sure the directory approach works though, does it, as if you gave did |
This does open an opportunity for pain given that pulp is not the only build tool, though. Suppose someone who doesn't use pulp puts purescript code in a directory that does have dots; it would break only after a pulp user tried to compile it. We could change pulp's glob now, and fix the issue in the compiler later (the above situation seems so rare that I don't mind there being some short window of time where it might happen). |
Haha sorry I didn't see all these responses. Yes, I suppose we do want to stick with globbing then. |
ok! i will try (tho honestly probably not before a several hours have passed, and i get out of work.) |
Apologies. Tried and failed. I am too clueless at the moment apparently to get Pulp to build. I will post the error I am getting here, but I don't mean to make this drag on with my ignorance -- somebody who Knows What They Are Doing can address this issue later. :-) I am on commit 27743da of the pulp repo. I got purescript built on my linux x86 machine via 'stack'. I did 'bower update'.
|
Unfortunately |
That is: the problem here is that your |
This is resolved by |
Just created my first
pulp
project and ranpulp build
Same issue running test:
It works just fine, just curious about the message:
No files found using pattern: src/**/*.js
Feels like a warning to me?
PS: How do I use the
psc-ide
? It contains a server as well? https://github.com/kRITZCREEK/psc-ideI need stack, cabal, ... Don't know the Haskell environment.
For now I'm using the Atom plugin.
Thanks :)
The text was updated successfully, but these errors were encountered: