Fix finalization after failure #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears to have only worked coincidentaly before. When the interpreter enters into a finalization block, it puts a `Finalized` node onto the attempt stack with the current `step`. However if there was a failure, then step would be null. It "worked" before because there was stale state, and `fail` could be preserved through finalization. This bug was exposed by using `catchError` within the finalization block, which resets the failure state to null. Thus when it resumes after finalization, both `step` and `fail` are null, which is an invalid state. The solution is to preserve `fail` in addition to `step` in a `Finalized` node.
|
@felixSchl Can you confirm this fixes your issue? I have a suspicion that there are other bugs caused by this sort of state falling through, but I can merge this and investigate that in a follow up PR. |
|
Hey, sorry for the delay. It does indeed appear to fix the problem 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears to have only worked coincidentally before. When the
interpreter enters into a finalization block, it puts a
Finalizednodeonto the attempt stack with the current
step. However if there wasa failure, then step would be null. It "worked" before because there was
stale state, and
failcould be preserved through finalization. Thisbug was exposed by using
catchErrorwithin the finalization block,which resets the failure state to null. Thus when it resumes after
finalization, both
stepandfailare null, which is an invalidstate. The solution is to preserve
failin addition tostepina
Finalizednode.Fixes #159