Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v0.15.0 #40

Conversation

sigma-andex
Copy link
Contributor

  • Use es modules
  • Use spago
  • Update dependencies

- Use es modules
- Use spago
- Update dependencies
@sigma-andex
Copy link
Contributor Author

@sharkdp this test failed and only passes with the change made. I am not sure whether this correct.

@sharkdp
Copy link
Collaborator

sharkdp commented Mar 25, 2022

@sharkdp this test failed and only passes with the change made. I am not sure whether this correct.

well, that is.. unexpected? Are there some upstream changes that would indicate a breaking change?

packages.dhall Outdated Show resolved Hide resolved
@sigma-andex
Copy link
Contributor Author

@sharkdp this test failed and only passes with the change made. I am not sure whether this correct.

well, that is.. unexpected? Are there some upstream changes that would indicate a breaking change?

I haven't found anything... not sure what to think about this.

Apart from that, the 0.15 update is now complete

package.json Outdated
},
"devDependencies": {
"bower": "^1.8.12",
"pulp": "^15.0.0",
"pulp": "^16.0.0-0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 16.0.0 now.

@JordanMartinez
Copy link
Contributor

@sigma-andex Is this PR using spago@0.20.8 now?

Also, mind adding a ToString for BigInt, which can reflect type-level Ints to a BigInt? Something like this should work:

import Prim.Int (class ToString)
import Data.Reflectable (class Reflectable)

reflectBigInt :: forall i. ToString i sym => Reflectable sym String => Proxy i -> BigInt
reflectBigInt p = fromString $ reflectType p

@sigma-andex
Copy link
Contributor Author

import Prim.Int (class ToString)
import Data.Reflectable (class Reflectable)

Not sure if this is possible, fromString returns a Maybe

@JordanMartinez
Copy link
Contributor

import Prim.Int (class ToString)
import Data.Reflectable (class Reflectable)

Not sure if this is possible, fromString returns a Maybe

fromString has to return Maybe because it must work on all String types. However, if we can guarantee that the String type stores an integer, which it does in this case, then we don't need that Maybe.

So, we should actually just use fromBase here, but without the Maybe wrapper. In other words, exposing FFI to just this function and using that in the implementation.

Copy link
Collaborator

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JordanMartinez
Copy link
Contributor

This PR should now be ready to go.

@sigma-andex
Copy link
Contributor Author

Thx @JordanMartinez

@thomashoneyman thomashoneyman merged commit e55d1b5 into purescript-contrib:master May 3, 2022
@thomashoneyman thomashoneyman deleted the v0.15.0-update branch May 3, 2022 18:09
@thomashoneyman
Copy link
Collaborator

https://pursuit.purescript.org/packages/purescript-bigints/7.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants