Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more standard pseudo-classes #82

Closed
wants to merge 1 commit into from
Closed

Add more standard pseudo-classes #82

wants to merge 1 commit into from

Conversation

vyorkin
Copy link
Collaborator

@vyorkin vyorkin commented Jul 5, 2018 •
edited
Loading

vyorkin
vyorkin commented Jul 6, 2018
View reviewed changes
src/CSS/Pseudo.purs
link :: Refinement
link = fromString ":link"

-- TODO: not, nth-child, nth-last-child
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to implement this yet, so I've left several TODOs for those I had to skip

vyorkin
vyorkin commented Jul 6, 2018
View reviewed changes
src/CSS.purs
@@ -14,7 +14,7 @@ import CSS.Geometry (bottom, height, left, lineHeight, margin, marginBottom, mar
import CSS.Gradient (Extend, Radial, Ramp, circle, circular, closestCorner, closestSide, ellipse, elliptical, farthestCorner, farthestSide, hGradient, hRepeatingGradient, linearGradient, radialGradient, repeatingLinearGradient, repeatingRadialGradient, vGradient, vRepeatingGradient) as X
import CSS.Property (class Val, Key(..), Literal(..), Prefixed(..), Value(..), cast, noCommas, plain, quote, value, (!)) as X
import CSS.Render (Inline(..), Rendered, Sheet(..), collect, collect', face, feature, frame, getInline, getSheet, imp, kframe, mediaQuery, mediaType, merger, nel, predicate, properties, putInline, putStyleSheet, query', render, renderedInline, renderedSheet, rule', rules, selector, selector', selector'', sepWith) as X
import CSS.Pseudo (hover) as X
import CSS.Pseudo (active, any, anyLink, checked, default, defined, disabled, empty, enabled, first, firstChild, firstOfType, fullscreen, focus, focusVisible, hover, indeterminate, inRange, invalid, lastChild, lastOfType, link, onlyChild, onlyOfType, optional, outOfRange, readOnly, readWrite, required, root, scope, target, valid, visited) as X
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not re-exporting left and right here because there are two CSS properties with the same names that are already exported from the CSS.Geometry module and I believe they are used more often

@vyorkin
Copy link
Collaborator Author

vyorkin commented Jul 28, 2018

I think it makes sense to add these pseudo-classes as part of #101, so I'm closing this PR

@vyorkin vyorkin closed this Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vyorkin