Merge pull request #22 from Ebmtranceboy/main

making sure NaN is not passed to BigInt constructor + 2 tests back

src/JS/BigInt.js

@@ -35,11 +35,11 @@ export const fromStringAsImpl = function (just) {
         while (i < value.length) parts.push(value.slice(i, i += size));
 
         function f(acc, chunk) {
-          let n = BigInt(parseInt(chunk, radix));
+          let n = parseInt(chunk, radix);
           if (isNaN(n)) {
             throw new Error("Invalid number");
           } else {
-            return acc * factor + n;
+            return acc * factor + BigInt(n);
           }
         };
 

test/Main.purs

@@ -80,12 +80,12 @@ main = do
   assert $ fromString "123456789" == Just (fromInt 123456789)
   assert $ fromString "10000000" == Just (fromInt 10000000)
   quickCheck $ \(TestBigInt a) -> (fromString <<< toString) a == Just a
-{-
+
   quickCheck $ \(TestBigInt a) -> 
     let radixes = [binary, octal, decimal, hexadecimal, base36]
     in un Conj $ flip foldMap radixes $ \r -> 
           Conj $ (fromStringAs r $ toStringAs r a) == Just a
--}
+
   log "Parsing strings with a different base"
   assert $ fromString "0b100" == Just four
   assert $ fromString "0xff" == fromString "255"
@@ -104,7 +104,7 @@ main = do
 
   log "Can parse 256 bit numbers"
   assert $ isJust $ fromString "115792089237316195423570985008687907853269984665640564039457584007913129639935"
-  -- assert $ isJust $ fromStringAs hexadecimal "ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff0cbf"
+  assert $ isJust $ fromStringAs hexadecimal "ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff0cbf"
 
   -- To test the multiplication, we need to make sure that Int does not overflow
   quickCheck (\x y -> fromSmallInt x * fromSmallInt y == fromInt (runSmallInt x * runSmallInt y))