-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD: Eq, Ord, and Show instances for JSDate #17
Merged
garyb
merged 9 commits into
purescript-contrib:master
from
eric-corumdigital:eric/jsdateinst
Mar 20, 2018
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
56fe21b
ADD: Eq, Ord, and Show instances for JSDate
eric-corumdigital 191d31b
ADD: fromTime to export list
eric-corumdigital 357aeec
ADD: Generics
eric-corumdigital 017c4a2
CHG: Generic constructor name to "fromTime" from "JSDate" so that
eric-corumdigital 9527ae1
Revert "ADD: fromTime to export list"
eric-corumdigital 8fb3ef8
Revert "CHG: Generic constructor name to "fromTime" from "JSDate" so …
eric-corumdigital e8d1d6c
Revert "Revert "CHG: Generic constructor name to "fromTime" from "JSD…
eric-corumdigital b72edd8
Revert "ADD: Generics"
eric-corumdigital d0bc2db
ADD: fromTime to export list
eric-corumdigital File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fromTime
isn't exported or used?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It already exists as
fromInstant
too, I'd prefer we use that instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fromTime
copes withNaN
and out of boundNumber
s in the native way, which is not something that makes much sense withInstant
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the
fromTime
export? Then I'll finally get this merged in and released.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it disappeared again in the convoluted reversion process 😉