Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning to documentation about parametricity #7

Closed
rightfold opened this issue Sep 20, 2016 · 0 comments
Closed

Add warning to documentation about parametricity #7

rightfold opened this issue Sep 20, 2016 · 0 comments

Comments

@rightfold
Copy link

I think this library breaks parametricity.

toMaybe (toNullable (Just somethingNull)) /= Just somethingNull

but

toMaybe (toNullable (Just 1)) == Just 1

Should this be documented?
@hdgarrood hdgarrood mentioned this issue Jan 11, 2019
Closed
hdgarrood added a commit that referenced this issue Jan 12, 2019
@hdgarrood
Merge pull request #23 from purescript-contrib/document-pitfalls
4dd36e4 
Document pitfalls of Nullable, fixes #7, resolves #2
ajnsit added a commit to ajnsit/purescript-nullable that referenced this issue Nov 27, 2019
@ajnsit
Add a test to verify that we don't violate parametricity
aaef27f 
See purescript-contrib#7
ajnsit added a commit to ajnsit/purescript-nullable that referenced this issue Nov 27, 2019
@ajnsit
Add a test to verify that we don't violate parametricity
aa900eb 
See purescript-contrib#7
@ajnsit ajnsit mentioned this issue Nov 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rightfold