Fix integer overflow test with Ints #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
test/Test/Prim/Int.purs
Outdated
Comment on lines
12
to
13
| -- | Necessary for the EuclideanRing test | ||
| -- | so as to prevent integer overflow when multiplying large integer values |
There was a problem hiding this comment.
What do you think of naming this SmallInt instead, usable to avoid overflows when testing large integer values? It doesn't seem specific to EuclideanRing other than that we're using it in a test for it.
There was a problem hiding this comment.
Now that #57 is in, this could be refactored to use the gen version and not even need this newtype.
test/Test/Prim/Int.purs
Outdated
Comment on lines
20
to
22
| instance arbitraryEuclideanRingInt :: Arbitrary EuclideanRingInt where | ||
| arbitrary = do | ||
| EuclideanRingInt <$> chooseInt (-10_000) 10_000 |
There was a problem hiding this comment.
Suggested change
| instance arbitraryEuclideanRingInt :: Arbitrary EuclideanRingInt where | |
| arbitrary = do | |
| EuclideanRingInt <$> chooseInt (-10_000) 10_000 | |
| instance arbitraryEuclideanRingInt :: Arbitrary EuclideanRingInt where | |
| arbitrary = EuclideanRingInt <$> chooseInt (-10_000) 10_000 |
Is there a reason for -10_000 to 10_000 specifically?
There was a problem hiding this comment.
Number.MAX_SAFE_INTEGER is 9007199254740991. I figured 10k was a large enough range to test without being too large to produce the overflow.
thomashoneyman
approved these changes
Sep 27, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixes #30.
Checklist: