-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use BigInt instead of Int #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this and it works, so I think it's good to merge
The only things to do I think should be:
|
I think it would be better to make this depend on |
I think the same thing now that bigints are widely adopted by browsers. |
Done! https://github.com/purescript-contrib/purescript-js-bigints |
Any news on this? |
Hi, Sorry for the delay. |
New release is out! (thanks @sigma-andex) |
Since js-bigints 2.1 is now present in the last package-set, I have replaced bigints with js-bigints as object behind Rational |
@f-f or someone else, |
I have created a branch gbagan-master that resolve conflicts. |
You could merge the new branch in here, but making a new PR is just easier! I can review that right away |
Closing in favour of #42 |
This ia PR following the advice of @hdgarrood #33
The changes are:
Ratio BigInt
.bigints
and remove the dependency onintegers
The readme needs to be updated.