fix #37 #39
Merged
fix #37 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyb
requested changes
Sep 23, 2017
src/Routing/Parser.purs
Outdated
| @@ -36,4 +40,4 @@ parsePart str = fromMaybe (Path str) do | |||
| -- | applied to every hash part (usually `decodeURIComponent`) | |||
| parse :: (String -> String) -> String -> Route | |||
| parse decoder hash = | |||
| map ( decoder >>> parsePart ) $ fromFoldable (S.split (S.Pattern "/") hash) | |||
| map ( decoder >>> parsePart ) $ fromFoldable (R.split (unsafePartial fromRight $ R.regex "\\/|(?=\\?)" R.noFlags) hash) | |||
There was a problem hiding this comment.
Can you move the pattern out into a toplevel definition please? 👍 after that.
|
Nice, after the merge I'll be able to delete a workaround in cofree-react-router. |
|
Yeah, sorry, I didn't realise there were a bunch of outstanding PRs until I saw the Aff one. All released now 😄. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.