Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#682): Properties -> add style attr function #692

Merged
merged 2 commits into from
Aug 27, 2020

Conversation

srghma
Copy link
Contributor

@srghma srghma commented Jul 31, 2020

No description provided.

@thomashoneyman
Copy link
Member

@srghma I'm on board with this change. Historically Halogen has omitted the property so as to encourage use of typed css via purescript-halogen-css, but I don't think it's necessary to enforce that via omission.

Still, it is good for folks to know they can use typed CSS if they would like to. Can you add a documentation comment like the one below to this property?

-- | Sets the `style` attribute to the specified string.
-- |
-- | ```purs
-- | ... [ style "height: 50px;" ]
-- | ```
-- |
-- | If you prefer to use typed CSS for this attribute, you can use the purescript-halogen-css library:
-- | https://github.com/purescript-halogen/purescript-halogen-css

@garyb let me know if you'd prefer not to mention halogen-css here; otherwise I'm happy to merge with this comment.

@thomashoneyman thomashoneyman self-assigned this Jul 31, 2020
@thomashoneyman thomashoneyman merged commit 07ca612 into purescript-halogen:master Aug 27, 2020
srghma added a commit to srghma/purescript-halogen that referenced this pull request Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants