Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memoized #743

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Fix memoized #743

merged 1 commit into from
Apr 15, 2021

Conversation

thomashoneyman
Copy link
Member

Fixes #742 by using the same non-eta-expanded implementation as Spork. I tested this locally by updating the components-inputs example to use the previous implementation and the Spork implementation and could verify that the memoized function only works when done the Spork way.

@thomashoneyman
Copy link
Member Author

If desired, I could also add a new example that demonstrates the lazy and memoized functions in action. It would most likely require unsafe logging in the render function to prove that the render fired or didn't fire.

@garyb
Copy link
Member

garyb commented Apr 7, 2021

Did you test it that way already after updating the implementation? I'm fine to skip including that in here, but it'd be good to know that it has been seen to work when we merge this 😄

@thomashoneyman
Copy link
Member Author

I adjusted the existing components-inputs example to make sure this works :) I’d like to add a new example, though, just so we can more easily test in the future.

@thomashoneyman
Copy link
Member Author

#747 demonstrates that this update does indeed fix the memoized function.

@thomashoneyman thomashoneyman merged commit 2015be0 into purescript-halogen:master Apr 15, 2021
@thomashoneyman thomashoneyman deleted the fix-memoized branch April 15, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

memoized doesn't seem to work
2 participants