Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add join operation for forks #792

Merged
merged 2 commits into from
May 2, 2022
Merged

Add join operation for forks #792

merged 2 commits into from
May 2, 2022

Conversation

garyb
Copy link
Member

@garyb garyb commented May 2, 2022

No description provided.

natefaubion
natefaubion reviewed May 2, 2022
View reviewed changes
src/Halogen/Aff/Driver/Eval.purs Outdated
@@ -123,6 +123,11 @@ evalM render initRef (HalogenM hm) = foldFree (go initRef) hm
liftEffect $ unlessM (Ref.read doneRef) do
Ref.modify_ (M.insert fid fiber) forks
pure (k fid)
Join fid a -> do
DriverState ({ forks }) <- liftEffect (Ref.read ref)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary parens.

@garyb
Copy link
Member Author

garyb commented May 2, 2022

Thanks!

@garyb garyb merged commit a1f1eb6 into purescript-halogen:purs-0.15 May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

@natefaubion natefaubion natefaubion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garyb @natefaubion @thomashoneyman