馃摑 Fix broken links #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -132,7 +132,7 @@ foreign import myEff :: forall eff. Eff (myEff :: MYEFF | eff) SomeType | |||
| ``` | |||
|
|
|||
| ## FFI Libraries | |||
| There are a number of libraries for easing the process or writing FFI code. @paf31 wrote an [introduction](https://gist.github.com/paf31/8e9177b20ee920480fbc#day-3---purescript-easy-ffi-and-purescript-oo-ffi) to these in his 2014 ["24 Days of PureScript"](https://gist.github.com/paf31/8e9177b20ee920480fbc). Note that it shows the now deprecated (as of PureScript 0.7.0) inline FFI. | |||
| There are a number of libraries for easing the process or writing FFI code. @paf31 wrote an [introduction](https://github.com/paf31/24-days-of-purescript-2014/blob/master/3.markdown) to these in his 2014 ["24 Days of PureScript"](https://gist.github.com/paf31/8e9177b20ee920480fbc). Note that it shows the now deprecated (as of PureScript 0.7.0) inline FFI. | |||
There was a problem hiding this comment.
This is really out of date, the FFI doesn't look like it did when https://github.com/paf31/24-days-of-purescript-2014/blob/master/3.markdown was written.
There was a problem hiding this comment.
@LiamGoodacre Thanks for the feedback. Tbh I haven't even gotten as far as the FFI in my purescript journey. From what I could determine, this new link is where the old one got moved to. Maybe we need a new issue to update this part so that it no longer needs to point to that? :)
There was a problem hiding this comment.
We can deal with this being out of date later, I think. I think this FFI tips page can be merged into the FFI guide in the guides/ subdirectory, potentially.
|
This is great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1.